13 Apr 2009

I see at least 4 things wrong with this code

1 Comment Uncategorized

I saw this code over on Ayende’s website. I see at least 4 things wrong with this code, which was found here.

public object DeepCopy (object value) 
{
    try {
        return value;
    } catch (Exception ex) {
        throw ex;
    }
}

See if you can find them all.

Tags: ,
written by
Nick Berardi
subscribe
If you found this post valuable and would like to see more like it you can follow me.

One Response to “I see at least 4 things wrong with this code”

  1. Reply Lee Dumond says:

    1. It doesn’t actually copy anything (except for the reference).

    2. It catches System.Exception, which is generally pointless.

    3. It doesn’t actually handle the exception. If you aren’t going to handle it why catch it?

    4. It resets the call stack.

    Goes to show you how much credibility CodeProject has.

Leave a Reply